Since Cd(II) and As(III) have extremely opposite chemical characteristics, it is a huge challenging to simultaneously remove these two ions from aqueous solutions. Therefore, a novel iron sulfide-based porous biochar (FSB) was synthesized and used to evaluate its Cd(II) and As(III) removal performance and mechanisms. The characterization and batch experiments results indicated that FeS was successfully loaded on the surface of biochar and increased its adsorption sites. The iron sulfide-based porous biochar was very favorable for the removal of Cd(II) and As(III) in the weakly acidic environment. The maximum adsorption of Cd(II) and As(III) by FSB was 108.8 mg g-1 and 76.3 mg g-1, respectively, according to the Langmuir and Freundlich isothermal adsorption model, and the adsorption equilibrium time was 12 h and 4 h, respectively, according to the pseudo-second-order kinetic model. In the coexisting ion system, Cd(II) adsorption was suppressed by Ca2+, Mg2+, and humic acid, but enhanced by PO43- and As(III). As(III) adsorption was inhibited by PO43- and humic acid. Precipitation and complexation are the predominant adsorption mechanisms of Cd(II) and As(III), which contribute to the formation of Cd-O, Fe-O-Cd, As-O, Fe-O-As, ternary complex Cd-Fe-As, and stable compounds FeAsO4 center dot 2H2O and CdS. Therefore, The iron sulfide-based porous biochar can be an efficient and environmentally friendly candidate for the treatment of Cd(II) and As(III) co-polluted irrigation water.